Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish code #1

Closed
wants to merge 1 commit into from
Closed

Polish code #1

wants to merge 1 commit into from

Conversation

donat
Copy link

@donat donat commented Oct 5, 2017

  • Rearrange plugin.xml content in UI plugin
  • Format GradleDocumentSetupParticipant and adjust javadoc
  • Adjust GradleEditor
  • Refactor GraleEditorContributor action to separate RefreshGradleProjectAction
  • Format GradlePresentationScanner
  • Clean up editor constants
  • Clean up GradlePresentationReconciler

@donat
Polish code
3a92196 
 - Rearrange plugin.xml content in UI plugin
 - Format GradleDocumentSetupParticipant and adjust javadoc
 - Adjust GradleEditor
 - Refactor GraleEditorContributor action to separate RefreshGradleProjectAction
 - Format GradlePresentationScanner
 - Clean up editor constants
 - Clean up GradlePresentationReconciler

Signed-off-by: Donat Csikos <csdonat@gmail.com>
@donat donat force-pushed the donat/pr/cmoine-editor-support-cleanup branch from c37bf6f to 3a92196 Compare October 5, 2017 08:45
@cmoine
Copy link
Owner

cmoine commented Oct 5, 2017

Wow, awesome work, thanks. However, I personally prefer IGradlePartitions instead of GradleEditorConstants since this naming convention seems to be more used in Eclipse: IJavaPartitions, IPropertiesFilePartitions, ... Yes actually it is mainly JDT :) It is not very important anyway.

What do think ? Appart from that, nothing to say :)

@donat
Copy link
Author

donat commented Oct 6, 2017

Thanks for checking!
As of the 'I' prefix for interfaces, it was a conscious decision that we don't use them.

@donat donat closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@donat @cmoine