Skip to content

Commit

Permalink
Fixed bug with native gem generation.
Browse files Browse the repository at this point in the history
Task was inserting 'compile:mri' into gem_spec.files, causing rubygems to complain that the file wasn't found.  Fixed by using ext_name instead of task prerequisites.
  • Loading branch information
eclubb committed Jan 27, 2009
1 parent 9b27dd0 commit 4c9b059
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tasks/ext_helper.rb 100644 → 100755
Expand Up @@ -58,7 +58,7 @@ def setup_c_extension(extension_name, gem_spec = nil)

# add the precompiled binaries to the list of files
# (taken from compile task dependency)
gem_spec.files += Rake::Task['compile'].prerequisites
gem_spec.files += ["lib/#{ext_name}"]
end
end
end
Expand Down

1 comment on commit 4c9b059

@luislavena
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this down.

The thing is that ext_helper was deprecated and replaced by rake-compiler:

http://www.github.com/luislavena/rake-compiler

http://github.com/datamapper/do/blob/9b27dd04d39cbba1d6269291cb2a6e74f9d211ba/do_sqlite3/Rakefile#L202-216

I’ll see if I have commits right to the new repository and pull your change.

Thank you.

Please sign in to comment.