Refactor: Removed an iterator by using Enumerable's partition method

edavis10 · Jan 29, 2010 · 420879f · 420879f
1 parent 0178a90
commit 420879f
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/app/helpers/bulk_time_entries_helper.rb b/app/helpers/bulk_time_entries_helper.rb
@@ -11,15 +11,7 @@ def label_for_field(field, rnd_id, options = { })
   end
 
   def grouped_options_for_issues(issues)
-    open_issues = []
-    closed_issues = []
-    issues.each do |issue|
-      if issue.closed?
-        closed_issues << issue
-      else
-        open_issues << issue
-      end
-    end
+    closed_issues, open_issues = *issues.partition {|issue| issue.closed?}
 
     html = '<option></option>'
     unless open_issues.empty?