Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor: split NewsController#new into #new and #create methods.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4163 e93f8b46-1217-0410-a6f0-8f06a7374b81
- Loading branch information
Showing
7 changed files
with
18 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,9 @@ | |
class NewsController < ApplicationController | ||
default_search_scope :news | ||
model_object News | ||
before_filter :find_model_object, :except => [:new, :index, :preview] | ||
before_filter :find_project_from_association, :except => [:new, :index, :preview] | ||
before_filter :find_project, :only => [:new, :preview] | ||
before_filter :find_model_object, :except => [:new, :create, :index, :preview] | ||
before_filter :find_project_from_association, :except => [:new, :create, :index, :preview] | ||
before_filter :find_project, :only => [:new, :create, :preview] | ||
before_filter :authorize, :except => [:index, :preview] | ||
before_filter :find_optional_project, :only => :index | ||
accept_key_auth :index | ||
|
@@ -46,11 +46,17 @@ def show | |
|
||
def new | ||
@news = News.new(:project => @project, :author => User.current) | ||
end | ||
|
||
def create | ||
@news = News.new(:project => @project, :author => User.current) | ||
if request.post? | ||
@news.attributes = params[:news] | ||
if @news.save | ||
flash[:notice] = l(:notice_successful_create) | ||
redirect_to :controller => 'news', :action => 'index', :project_id => @project | ||
else | ||
render :action => 'new' | ||
end | ||
end | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
edavis10
Author
Owner
|
||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't this miss a 'render' if the !post case?
Or probably better, similarly as other controllers:
if request.post? && @news.update_attributes(params[:news])