Skip to content

Commit

Permalink
Refactor: Remove duplicated case statements.
Browse files Browse the repository at this point in the history 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3554 e93f8b46-1217-0410-a6f0-8f06a7374b81
  • Loading branch information
@edavis10
edavis10 committed Mar 8, 2010
1 parent 43e3c43 commit c07696b
Showing 1 changed file with 6 additions and 22 deletions.
28 changes: 6 additions & 22 deletions app/helpers/issues_helper.rb
View file
Expand Up @@ -69,32 +69,16 @@ def show_detail(detail, no_html=false)
when 'attr'
field = detail.prop_key.to_s.gsub(/\_id$/, "")
label = l(("field_" + field).to_sym)
case detail.prop_key
when 'due_date', 'start_date'
case
when ['due_date', 'start_date'].include?(detail.prop_key)
value = format_date(detail.value.to_date) if detail.value
old_value = format_date(detail.old_value.to_date) if detail.old_value
when 'project_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'status_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'tracker_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'assigned_to_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'priority_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'category_id'
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'fixed_version_id'

when ['project_id', 'status_id', 'tracker_id', 'assigned_to_id', 'priority_id', 'category_id', 'fixed_version_id'].include?(detail.prop_key)
value = find_name_by_reflection(field, detail.value)
old_value = find_name_by_reflection(field, detail.old_value)
when 'estimated_hours'

when detail.prop_key == 'estimated_hours'
value = "%0.02f" % detail.value.to_f unless detail.value.blank?
old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
end
Expand Down

2 comments on commit c07696b

@edavis10
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blogged about at http://theadmin.org/articles/2010/03/09/inline-method-in-issues-helper-show_detail/

@schmidt
Copy link

@schmidt schmidt commented on c07696b Mar 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring looks like a great code saver.

I have a short question, though. Why did you use include? on literal arrays? Shouldn't the following outline be functionally equal but more straight forward or am I missing the essence of this refactoring somehow?

case detail.prop_key
when 'due_date', 'start_date'
  ...
when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id', 'priority_id', 'category_id', 'fixed_version_id'
  ...
when 'estimated_hours'
  ...
end

Please sign in to comment.