Refactor: Remove Kanban#find, leftover from the refactorings.

edavis10 · Apr 9, 2010 · b4f589d · b4f589d
1 parent 243d3a5
commit b4f589d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 15 deletions.
diff --git a/app/controllers/kanbans_controller.rb b/app/controllers/kanbans_controller.rb
@@ -7,7 +7,7 @@ class KanbansController < ApplicationController
 
   def show
     @settings = Setting.plugin_redmine_kanban
-    @kanban = Kanban.find
+    @kanban = Kanban.new
   end
 
   def update
@@ -20,7 +20,7 @@ def update
 
     saved = Kanban.update_issue_attributes(params[:issue_id], params[:from], params[:to], User.current, @to_user)
 
-    @kanban = Kanban.find
+    @kanban = Kanban.new
     respond_to do |format|
 
       if saved

diff --git a/app/models/kanban.rb b/app/models/kanban.rb
@@ -41,10 +41,6 @@ def self.staffed_panes
     ['active','testing','finished','canceled']
   end
 
-  def self.find
-    Kanban.new
-  end
-
   def incoming_issues
     @incoming_issues ||= incoming_pane.get_issues
   end

diff --git a/test/unit/kanban_test.rb b/test/unit/kanban_test.rb
@@ -18,7 +18,7 @@ def shared_setup
     context "for incoming issues" do
       setup {
         setup_incoming_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get incoming issues up to the limit" do
@@ -35,7 +35,7 @@ def shared_setup
     context "for backlog issues" do
       setup {
         setup_backlog_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get backlog issues up to the limit" do
@@ -69,7 +69,7 @@ def shared_setup
     context "for quick issues" do
       setup {
         setup_quick_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get quick issues up to the limit" do
@@ -94,7 +94,7 @@ def shared_setup
     context "for selected issues" do
       setup {
         setup_selected_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "get all selected issues" do
@@ -112,7 +112,7 @@ def shared_setup
       setup {
         setup_active_issues
         setup_unknown_user_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get all active issues" do
@@ -139,7 +139,7 @@ def shared_setup
       setup {
         setup_testing_issues
         setup_unknown_user_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get all testing issues" do
@@ -165,7 +165,7 @@ def shared_setup
     context "for finished issues" do
       setup {
         setup_finished_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get issues with the configured Finished status" do
@@ -194,7 +194,7 @@ def shared_setup
     context "for canceled issues" do
       setup {
         setup_canceled_issues
-        @kanban = Kanban.find
+        @kanban = Kanban.new
       }
 
       should "only get issues with the configured Canceled status" do
@@ -221,7 +221,7 @@ def shared_setup
     end
 
     should "set @users based on the configured role" do
-      @kanban = Kanban.find
+      @kanban = Kanban.new
       assert_equal 5, @kanban.users.length # +1 Unknown
     end
   end