feat: Send max-age header as well as expires if it is set(#27)

Co-authored-by: yancoding <junyan@junyandeMacBook-Pro.local>
eggjs · Jun 22, 2020 · 4417dda · 4417dda
1 parent 9d1e77a
commit 4417dda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/cookie.js b/lib/cookie.js
@@ -44,8 +44,11 @@ class Cookie {
   toHeader() {
     let header = this.toString();
     const attrs = this.attrs;
-    if (attrs.maxAge) attrs.expires = new Date(Date.now() + attrs.maxAge);
     if (attrs.path) header += '; path=' + attrs.path;
+    if (attrs.maxAge) {
+      header += '; max-age=' + Math.round(attrs.maxAge / 1000);
+      attrs.expires = new Date(Date.now() + attrs.maxAge);
+    }
     if (attrs.expires) header += '; expires=' + attrs.expires.toUTCString();
     if (attrs.domain) header += '; domain=' + attrs.domain;
     if (attrs.sameSite) header += '; samesite=' + (attrs.sameSite === true ? 'strict' : attrs.sameSite.toLowerCase());

diff --git a/test/lib/cookie.test.js b/test/lib/cookie.test.js
@@ -34,7 +34,7 @@ describe('test/lib/cookie.test.js', () => {
         domain: 'eggjs.org',
         path: '/',
         httpOnly: true,
-      }).toHeader().match(/^name=value; path=\/; expires=(.*?)GMT; domain=eggjs\.org; secure; httponly$/));
+      }).toHeader().match(/^name=value; path=\/; max-age=1; expires=(.*?)GMT; domain=eggjs\.org; secure; httponly$/));
     });
 
     it('donnot set path when set path to null', () => {