chore: no need to consume stream on error throw (#18)

The stream will be auto consume by koa-onerror
see koajs/onerror#33

closes eggjs/egg#2897

README.md

@@ -135,15 +135,8 @@ module.exports = Class UploadController extends Controller {
     // file not exists will response 400 error
     const stream = await ctx.getFileStream();
     const name = 'egg-multipart-test/' + path.basename(stream.filename);
-    let result;
-    try {
-      // process file or upload to cloud storage
-      result = await ctx.oss.put(name, stream);
-    } catch (err) {
-      // must consume the stream, otherwise browser will be stuck.
-      await sendToWormhole(stream);
-      throw err;
-    }
+    // process file or upload to cloud storage
+    const result = await ctx.oss.put(name, stream);
 
     ctx.body = {
       url: result.url,
@@ -159,14 +152,8 @@ module.exports = Class UploadController extends Controller {
     let result;
     if (stream.filename) {
       const name = 'egg-multipart-test/' + path.basename(stream.filename);
-      try {
-        // process file or upload to cloud storage
-        result = await ctx.oss.put(name, stream);
-      } catch (err) {
-        // must consume the stream, otherwise browser will be stuck.
-        await sendToWormhole(stream);
-        throw err;
-      }
+      // process file or upload to cloud storage
+      const result = await ctx.oss.put(name, stream);
     } else {
       // must consume the empty stream
       await sendToWormhole(stream);
@@ -195,7 +182,6 @@ Controller which hanlder `POST /upload`:
 
 ```js
 // app/controller/upload.js
-const sendToWormhole = require('stream-wormhole');
 const Controller = require('egg').Controller;
 
 module.exports = Class UploadController extends Controller {
@@ -222,13 +208,7 @@ module.exports = Class UploadController extends Controller {
         console.log('filename: ' + part.filename);
         console.log('encoding: ' + part.encoding);
         console.log('mime: ' + part.mime);
-        let result;
-        try {
-          result = await ctx.oss.put('egg-multipart-test/' + part.filename, part);
-        } catch (err) {
-          await sendToWormhole(part);
-          throw err;
-        }
+        const result = await ctx.oss.put('egg-multipart-test/' + part.filename, part);
         console.log(result);
       }
     }

package.json

@@ -59,6 +59,7 @@
     "is-type-of": "^1.0.0",
     "mkdirp": "^0.5.1",
     "mz": "^2.7.0",
+    "mz-modules": "^2.1.0",
     "stream-wormhole": "^1.0.3",
     "supertest": "^3.0.0",
     "urllib": "^2.29.1",

test/fixtures/apps/multipart/app/controller/upload.js

@@ -37,6 +37,10 @@ module.exports = async ctx => {
     };
   }
 
+  if (ctx.query.mock_undefined_error) {
+    part.foo();
+  }
+
   const filepath = path.join(ctx.app.config.logger.dir, 'multipart-test-file');
   await saveStream(part, filepath);
   ctx.body = {

test/fixtures/apps/upload-one-file/app/controller/async.js

@@ -8,6 +8,10 @@ module.exports = app => {
     async async() {
       const ctx = this.ctx;
       const stream = await ctx.getFileStream();
+      if (ctx.query.foo === 'error') {
+        // mock undefined error
+        stream.foo();
+      }
       const name = 'egg-multipart-test/' + process.version + '-' + Date.now() + '-' + path.basename(stream.filename);
       const result = await ctx.oss.put(name, stream);
       ctx.body = {