fix: should transform jsx to js (#11)

eggjs · Apr 1, 2018 · 9d7fdac · 9d7fdac
1 parent eedc2a0
commit 9d7fdac
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 1 deletion.
diff --git a/lib/assets_context.js b/lib/assets_context.js
@@ -62,7 +62,7 @@ class Assets {
   }
 
   setEntry(entry) {
-    this.entry = entry;
+    this.entry = entry.replace(/\.jsx?$/, '.js');
     this.entryCss = entry.replace(/\.jsx?$/, '.css');
   }
 

diff --git a/test/assets.test.js b/test/assets.test.js
@@ -34,6 +34,14 @@ describe('test/assets.test.js', () => {
           .expect(/<script>window.__webpack_public_path__ = '\/';<\/script>/)
           .expect(200);
       });
+
+      it('should GET jsx', () => {
+        return app.httpRequest()
+          .get('/account')
+          .expect(/<link rel="stylesheet" href="http:\/\/127.0.0.1:8000\/account.css"><\/link>/)
+          .expect(/<script src="http:\/\/127.0.0.1:8000\/account.js"><\/script>/)
+          .expect(200);
+      });
     });
 
     describe('production', () => {

diff --git a/test/fixtures/apps/assets/app/controller/home.js b/test/fixtures/apps/assets/app/controller/home.js
@@ -9,6 +9,10 @@ class HomeController extends Controller {
     });
   }
 
+  async account() {
+    await this.ctx.render('account.jsx');
+  }
+
   async renderString() {
     await this.ctx.renderString('', {}, {
       viewEngine: 'assets',

diff --git a/test/fixtures/apps/assets/app/router.js b/test/fixtures/apps/assets/app/router.js
@@ -4,5 +4,6 @@ module.exports = app => {
   const { router, controller } = app;
 
   router.get('/', controller.home.index);
+  router.get('/account', controller.home.account);
   router.get('/renderString', controller.home.renderString);
 };
diff --git a/test/fixtures/apps/assets/app/view/account.jsx b/test/fixtures/apps/assets/app/view/account.jsx
diff --git a/test/fixtures/apps/assets/config/config.default.js b/test/fixtures/apps/assets/config/config.default.js
@@ -6,6 +6,7 @@ exports.keys = '123456';
 exports.view = {
   mapping: {
     '.js': 'assets',
+    '.jsx': 'assets',
   },
 };
 exports.assets = {