🐛 FIX: Allow override HttpClientNext (#5037)

#5000

lib/egg.js

@@ -52,6 +52,7 @@ class EggApplication extends EggCore {
     this.ContextLogger = ContextLogger;
     this.ContextHttpClient = ContextHttpClient;
     this.HttpClient = HttpClient;
+    this.HttpClientNext = HttpClientNext;
 
     this.loader.loadConfig();
 
@@ -293,7 +294,7 @@ class EggApplication extends EggCore {
   get httpclient() {
     if (!this[HTTPCLIENT]) {
       if (this.config.httpclient.useHttpClientNext) {
-        this[HTTPCLIENT] = new HttpClientNext(this);
+        this[HTTPCLIENT] = new this.HttpClientNext(this);
       } else if (this.config.httpclient.enableDNSCache) {
         this[HTTPCLIENT] = new DNSCacheHttpClient(this);
       } else {

test/fixtures/apps/httpclient-next-overwrite/app.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const assert = require('assert');
+
+module.exports = app => {
+  class CustomHttpClient extends app.HttpClientNext {
+    request(url, opt) {
+      return new Promise(resolve => {
+        assert(/^http/.test(url), 'url should start with http, but got ' + url);
+        resolve();
+      }).then(() => {
+        return super.request(url, opt);
+      });
+    }
+
+    curl(url, opt) {
+      return this.request(url, opt);
+    }
+  }
+  app.HttpClientNext = CustomHttpClient;
+};

test/fixtures/apps/httpclient-next-overwrite/config/config.default.js

@@ -0,0 +1,8 @@
+'use strict';
+
+exports.httpclient = {
+  useHttpClientNext: true,
+  request: {
+    timeout: 99,
+  },
+};

test/fixtures/apps/httpclient-next-overwrite/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "httpclient-overwrite"
+}

test/lib/core/httpclient.test.js

@@ -260,6 +260,32 @@ describe('test/lib/core/httpclient.test.js', () => {
     });
   });
 
+  describe('overwrite httpclient support useHttpClientNext=true', () => {
+    let app;
+    before(() => {
+      app = utils.app('apps/httpclient-next-overwrite');
+      return app.ready();
+    });
+    after(() => app.close());
+
+    it('should set request default global timeout to 99ms', () => {
+      return app.httpclient.curl(`${url}/timeout`)
+        .catch(err => {
+          assert(err);
+          assert(err.name === 'HttpClientRequestTimeoutError');
+          assert(err.message.includes('Request timeout for 99 ms'));
+        });
+    });
+
+    it('should assert url', () => {
+      return app.httpclient.curl('unknown url')
+        .catch(err => {
+          assert(err);
+          assert(err.message.includes('url should start with http, but got unknown url'));
+        });
+    });
+  });
+
   describe('httpclient tracer', () => {
     let app;
     before(() => {