Fix matplotlib colormaps not loading properly #319
Conversation
| # See http://matplotlib.org/style_changes.html | ||
| if 'viridis' not in names: | ||
| names.append('viridis') | ||
| names.sort() |
There was a problem hiding this comment.
Can we be sure 'viridis' was loaded? Does this work with e.g. older matplotlib versions. I'm not sure how old we should support, but maybe something like 1.3.1?
There was a problem hiding this comment.
Good point. Would changing
cm = plt.get_cmap(name)
try:
add_matplotlib_cmap(cm, name=name)
except Exception as e:
...to
try:
cm = plt.get_cmap(name)
add_matplotlib_cmap(cm, name=name)
except Exception as e:
...be sufficient to address your concern?
There was a problem hiding this comment.
Hmm, I guess it works because if it is not present it gets thrown out in the exception handler below. @pllim, did you find it necessary to add this line to get 'viridis' to load with newer matplotlib versions?
There was a problem hiding this comment.
I have 1.5.1, which I think is sufficiently new. I need that line to find Viridis. For whatever reason, it does not get included automatically.
There was a problem hiding this comment.
You can double check to see if it is in plt.cm.datad.keys() in your own Matplotlib installation. If you find otherwise, please let me know, because then it could be something wrong with my Matplotlib installation.
There was a problem hiding this comment.
I'm fine with leaving the line in, but maybe we should add a comment to the effect that the line is there because the colormap is somehow not picked up automatically with "transition" versions of matplotlib (or something to that effect).
There was a problem hiding this comment.
Okay, I'll add that comment in this PR when I get the chance. Thanks!
|
Anyways, I also opened an issue with Matplotlib people about Viridis missing in the keys (See matplotlib/matplotlib#6316). |
…in case Viridis not in Matplotlib. Added a comment about Viridis.
|
@ejeschke , I think I addressed your concerns in my third commit to this PR. Please let me know if it is sufficient. Thanks! |
|
Looks good! |
|
Regarding the "viridis" map, on matplotlib 1.3.1 I now get a prominent print message "Error adding colormap 'viridis': Colormap viridis is not recognized" when starting up the reference viewer. I think that the code adding this name also needs to check whether this color map is actually available... |
|
Yikes, sorry for the trouble. I'll investigate a way to avoid a print out error tomorrow. One way is to only enable it for Matplotlib 1.5+ if I cannot find something more elegant. |
I found a bug where matplotlib colormaps were not being loaded even if requested in Python 2.7. It is because the colormap names were compared to
strwhen they are actuallyunicode.While I am at it, I also made sure the hot new "viridis" colormap is present:
Also added some much needed docstrings.