fix issue #83 and make sign function type more lenient #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit changes the type of the sign function so that it matches the type of negate. Also removes some duplicate code. |
RyanGlScott
requested changes
Nov 11, 2022
| @@ -706,7 +701,7 @@ integer' :: TokenParsing m => m Integer | |||
| integer' = int <?> "integer" | |||
| {-# INLINE integer' #-} | |||
|
|
|||
| sign :: TokenParsing m => m (Integer -> Integer) | |||
| sign :: (TokenParsing m, Num a) => m (a -> a) | |||
There was a problem hiding this comment.
I understand the intent behind this, but it is a somewhat unforced change, as it's not required to fix #83. Moreover, the existing convention in this module is to use Integer everywhere, so I'd favor sticking to that convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.