Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 2 vulnerabilities #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekmixon
Copy link
Owner

@ekmixon ekmixon commented Mar 15, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • src/pybind/mgr/dashboard/frontend/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Denial of Service (DoS)
SNYK-JS-DECODEURICOMPONENT-3149970
Yes Proof of Concept
high severity 589/1000
Why? Has a fix available, CVSS 7.5
Prototype Pollution
SNYK-JS-UNSETVALUE-2400660
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @compodoc/compodoc The new version differs by 179 commits.
  • 3d61871 1.1.13
  • 6266425 1.1.13
  • 7eb1d65 1.1.13
  • 72228fd fix(dark): better dark mode
  • f93090b fix(dark): better dark mode
  • f846caf feat(tools): move live-server to compodoc fork + update dependencies
  • fdfe925 feat(cli): Support --watch with --exportFormat json
  • 13546c0 fix(test): duplicates
  • a1f2c4b feat(app): add tests for modules informations in json export format
  • a1d5a1a fix(cli): remove sleep package | wait 10s if --inspect flag in CONTRIBUTING.md and docs/README.md
  • d2ad4fb Merge pull request Wip user quota ceph/ceph#1091 from joshcomley/develop
  • 74ed104 Mapping module missing data
  • 08a1f59 1.1.12
  • 8ef351f 1.1.12
  • 0f6e568 1.1.12
  • 6801707 feat(tools): update auto-changelog npm script
  • df2aba2 fix(app): directive with no option, and inheritance between component and directives
  • a6c678c fix(app): directive with no option, and inheritance between component and directives
  • 9544ad0 feat(app): update Angular APIs references
  • fc77cdb feat(app): bump dev/dependencies + Drop support for Node.js 10
  • 0b2ecde feat(app): @ deprecated support
  • 3226d01 fix(app): main comment parsing for ```
  • 909ae8a feat(app): bump dev/dependencies
  • 8190df5 fix(app): setters arguments correctly documented

See the full diff

Package name: jest The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Denial of Service (DoS)
🦉 Prototype Pollution

Micro-Learning Topic: Denial of service (Detected by phrase)

Matched on "Denial of Service"

The Denial of Service (DoS) attack is focused on making a resource (site, application, server) unavailable for the purpose it was designed. There are many ways to make a service unavailable for legitimate users by manipulating network packets, programming, logical, or resources handling vulnerabilities, among others. Source: https://www.owasp.org/index.php/Denial_of_Service

Try a challenge in Secure Code Warrior

Micro-Learning Topic: Prototype pollution (Detected by phrase)

Matched on "Prototype Pollution"

What is this? (2min video)

By adding or modifying attributes of an object prototype, it is possible to create attributes that exist on every object, or replace critical attributes with malicious ones. This can be problematic if the software depends on existence or non-existence of certain attributes, or uses pre-defined attributes of object prototype (such as hasOwnProperty, toString or valueOf).

Try a challenge in Secure Code Warrior

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ekmixon - I've reviewed your changes and they look great!

General suggestions:

  • Ensure that the major version upgrade of @angular-devkit/build-angular is thoroughly tested for compatibility with the project's Angular version and other dependencies.
  • Consider aligning the versions of @angular/cli, @angular/compiler-cli, and @angular/language-service with the upgraded Angular version to leverage new features and improvements.
  • Review the broader impact of the major version upgrades, especially for jest, on the project's testing framework and adjust configurations or tests as necessary.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants