Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json field extraction with mix of nested objects. #456

Closed
wants to merge 1 commit into from

Conversation

shawnsmith
Copy link
Contributor

Fixes #455.

Also fixes a case where matching on "a.b.c" and "a.d.c" would incorrectly result in the "a.b.c" matcher being set to the value of "a.d.c".

@costin
Copy link
Member

costin commented Jun 2, 2015

@shawnsmith thanks for the PR. Can you please sign the CLA?

@shawnsmith
Copy link
Contributor Author

@costin Hmm, I signed the CLA on May 19th. Did it get lost somehow? I have a confirmation email with a PDF copy of the "Individual Contributor License Agreement" document with the correct GitHub username.

@costin
Copy link
Member

costin commented Jun 2, 2015

Thanks for confirming - it's probably a system hiccup. I'll look into this shortly and merge it.
Cheers!

@costin
Copy link
Member

costin commented Jun 3, 2015

@shawnsmith I've merged the PR in. Thanks - the description and the test were valuable and the PR cleaned up the code as well - cheers!

As for the CLA - your PR is using a different email than the one in your github profile (and the one used for signing).

Let me know if you want to change the email of your commit or not.
As for the CLA, you can sign it using the PR email or add it to your Github profile (ping me once you do so I can pick it up).

Cheers,

@costin
Copy link
Member

costin commented Jun 3, 2015

@shawnsmith Let me know how you want to proceed in case of the commit (what email to use) so I know whether to push this into master as is or not.

@shawnsmith
Copy link
Contributor Author

@costin I've amended my commit to change the e-mail address to the one in my GitHub profile. That's the address I want to use for this. Thanks!.

@costin
Copy link
Member

costin commented Jun 3, 2015

I've picked up the latest PR and pushed it into master.

Thanks again.

@costin costin closed this Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json value extraction fails with mixed nested objects
2 participants