Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code generation to 1.5 #1370

Merged
merged 5 commits into from May 6, 2015
Merged

Update code generation to 1.5 #1370

merged 5 commits into from May 6, 2015

Conversation

gmarz
Copy link
Contributor

@gmarz gmarz commented May 4, 2015

Breaking changes that need to be addressed:

@gmarz gmarz added the WIP label May 4, 2015
@gmarz gmarz mentioned this pull request May 4, 2015
@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2015

I'm convinced the termvector changes are not correct.

I send a PR to include the changes introduces in: elastic/elasticsearch#7530

to both es master and 1.4 branches but they are no longer reflected in the 1.5 branches.

https://github.com/elastic/elasticsearch/blob/v1.4.5/rest-api-spec/api/termvector.json

https://github.com/elastic/elasticsearch/blob/v1.5.0/rest-api-spec/api/termvector.json

For now I'll manually revert these changes in our json and then send a PR to es core to update the specs in the 1.5 branches.

@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2015

IndicesPutAlias removed the ability to not specify {index} in the url causing the ForAll methods on the lowlevel client to dissapear, and the resulting dispatch code paths (which NEST never used to begin with).

Added them back (for 1.x binary assembly compatibility) but with obsolete messages that cause compiler failures since we won't be able to dispatch these any more.

@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2015

@gmarz I dont see IndicesGetRequestParameters in our develop or in the change set are you positive it wasn't always named GetIndexRequestParameters ? Looks like the manual rename was in place from the start

https://github.com/elastic/elasticsearch-net/blame/develop/src/Nest/DSL/GetIndexDescriptor.cs#L72-L73

@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2015

The full option on flush has been removed in 1.5 too elastic/elasticsearch#9559 and covered by @gmarz in this commit already.

@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2015

And I just see thats the first checked item already haha, these bwc code changes is is giving me googly eyes 👀

@gmarz
Copy link
Contributor Author

gmarz commented May 6, 2015

@Mpdreamz I don't see IndicesGetRequestParameters either...strange I could have sworn I saw it in the diff, but I must have been mistaken.

@gmarz
Copy link
Contributor Author

gmarz commented May 6, 2015

@Mpdreamz changes LGTM 👍

gmarz added a commit that referenced this pull request May 6, 2015
@gmarz gmarz merged commit a8927ee into develop May 6, 2015
@gmarz gmarz deleted the feature/code-gen-1.5 branch May 6, 2015 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants