Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11266 from brwe/npe-commitstats
fix NPE when streaming commit stats
- Loading branch information
Showing
2 changed files
with
54 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/test/java/org/elasticsearch/index/engine/CommitStatsTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
|
||
package org.elasticsearch.index.engine; | ||
|
||
import org.apache.lucene.index.SegmentInfos; | ||
import org.elasticsearch.common.io.stream.InputStreamStreamInput; | ||
import org.elasticsearch.common.io.stream.OutputStreamStreamOutput; | ||
import org.elasticsearch.test.ElasticsearchTestCase; | ||
|
||
import java.io.ByteArrayInputStream; | ||
import java.io.ByteArrayOutputStream; | ||
import java.io.IOException; | ||
|
||
import static org.elasticsearch.test.VersionUtils.randomVersion; | ||
|
||
|
||
public class CommitStatsTests extends ElasticsearchTestCase { | ||
public void testStreamingWithNullId() throws IOException { | ||
SegmentInfos segmentInfos = new SegmentInfos(); | ||
CommitStats commitStats = new CommitStats(segmentInfos); | ||
org.elasticsearch.Version targetNodeVersion = randomVersion(random()); | ||
|
||
ByteArrayOutputStream outBuffer = new ByteArrayOutputStream(); | ||
OutputStreamStreamOutput out = new OutputStreamStreamOutput(outBuffer); | ||
out.setVersion(targetNodeVersion); | ||
commitStats.writeTo(out); | ||
|
||
ByteArrayInputStream inBuffer = new ByteArrayInputStream(outBuffer.toByteArray()); | ||
InputStreamStreamInput in = new InputStreamStreamInput(inBuffer); | ||
in.setVersion(targetNodeVersion); | ||
CommitStats readCommitStats = CommitStats.readCommitStatsFrom(in); | ||
assertNull(readCommitStats.getId()); | ||
} | ||
} |