Skip to content

Commit

Permalink
Merge pull request #13718 from mikemccand/catch_throwable
Browse files Browse the repository at this point in the history
LoggingRunnable.run should catch and log all errors, not just Exception
  • Loading branch information
Michael McCandless committed Sep 23, 2015
2 parents 385c345 + de8eada commit 4fb6386
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -511,8 +511,8 @@ class LoggingRunnable implements Runnable {
public void run() {
try {
runnable.run();
} catch (Exception e) {
logger.warn("failed to run {}", e, runnable.toString());
} catch (Throwable t) {
logger.warn("failed to run {}", t, runnable.toString());
}
}

Expand Down

0 comments on commit 4fb6386

Please sign in to comment.