Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check ThreadInfo[] for null element if thread are not alive.
If a thread is not alive getting ThreadMXBean#getThreadInfo(long[], int) places null elemnents in the returned array which are not repected in the HotTheards API. Closes #4775
- Loading branch information
Showing
2 changed files
with
162 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
src/test/java/org/elasticsearch/action/admin/HotThreadsTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.elasticsearch.action.admin; | ||
|
|
||
| import org.elasticsearch.action.ActionListener; | ||
| import org.elasticsearch.action.admin.cluster.node.hotthreads.NodeHotThreads; | ||
| import org.elasticsearch.action.admin.cluster.node.hotthreads.NodesHotThreadsRequestBuilder; | ||
| import org.elasticsearch.action.admin.cluster.node.hotthreads.NodesHotThreadsResponse; | ||
| import org.elasticsearch.common.unit.TimeValue; | ||
| import org.elasticsearch.test.ElasticsearchIntegrationTest; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.ExecutionException; | ||
|
|
||
| import static org.elasticsearch.index.query.FilterBuilders.andFilter; | ||
| import static org.elasticsearch.index.query.FilterBuilders.notFilter; | ||
| import static org.elasticsearch.index.query.FilterBuilders.queryFilter; | ||
| import static org.elasticsearch.index.query.QueryBuilders.matchAllQuery; | ||
| import static org.elasticsearch.index.query.QueryBuilders.termQuery; | ||
| import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount; | ||
| import static org.hamcrest.CoreMatchers.equalTo; | ||
| import static org.hamcrest.CoreMatchers.notNullValue; | ||
|
|
||
| /** | ||
| */ | ||
| public class HotThreadsTest extends ElasticsearchIntegrationTest { | ||
|
|
||
| @Test | ||
| public void testHotThreadsDontFail() throws ExecutionException, InterruptedException { | ||
| /** | ||
| * This test just checks if nothing crashes or gets stuck etc. | ||
| */ | ||
| createIndex("test"); | ||
| final int iters = atLeast(2); | ||
|
|
||
| for (int i = 0; i < iters; i++) { | ||
| final String type; | ||
| NodesHotThreadsRequestBuilder nodesHotThreadsRequestBuilder = client().admin().cluster().prepareNodesHotThreads(); | ||
| if (randomBoolean()) { | ||
| TimeValue timeValue = new TimeValue(rarely() ? randomIntBetween(500, 5000) : randomIntBetween(20, 500)); | ||
| nodesHotThreadsRequestBuilder.setInterval(timeValue); | ||
| } | ||
| if (randomBoolean()) { | ||
| nodesHotThreadsRequestBuilder.setThreads(randomIntBetween(1, 100)); | ||
| } | ||
| if (randomBoolean()) { | ||
| switch (randomIntBetween(0, 2)) { | ||
| case 2: | ||
| type = "cpu"; | ||
| break; | ||
| case 1: | ||
| type = "wait"; | ||
| break; | ||
| default: | ||
| type = "block"; | ||
| break; | ||
| } | ||
| assertThat(type, notNullValue()); | ||
| nodesHotThreadsRequestBuilder.setType(type); | ||
| } else { | ||
| type = null; | ||
| } | ||
| final CountDownLatch latch = new CountDownLatch(1); | ||
| nodesHotThreadsRequestBuilder.execute(new ActionListener<NodesHotThreadsResponse>() { | ||
| @Override | ||
| public void onResponse(NodesHotThreadsResponse nodeHotThreads) { | ||
| try { | ||
| assertThat(nodeHotThreads, notNullValue()); | ||
| Map<String,NodeHotThreads> nodesMap = nodeHotThreads.getNodesMap(); | ||
| assertThat(nodesMap.size(), equalTo(cluster().size())); | ||
| for (NodeHotThreads ht : nodeHotThreads) { | ||
| assertNotNull(ht.getHotThreads()); | ||
| //logger.info(ht.getHotThreads()); | ||
| } | ||
| } finally { | ||
| latch.countDown(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Throwable e) { | ||
| logger.error("FAILED", e); | ||
| latch.countDown(); | ||
| fail(); | ||
| } | ||
| }); | ||
|
|
||
| indexRandom(true, | ||
| client().prepareIndex("test", "type1", "1").setSource("field1", "value1"), | ||
| client().prepareIndex("test", "type1", "2").setSource("field1", "value2"), | ||
| client().prepareIndex("test", "type1", "3").setSource("field1", "value3")); | ||
| ensureYellow(); | ||
| if (randomBoolean()) { | ||
| optimize(); | ||
| } | ||
| while(latch.getCount() > 0) { | ||
| assertHitCount( | ||
| client().prepareSearch() | ||
| .setQuery(matchAllQuery()) | ||
| .setPostFilter( | ||
| andFilter( | ||
| queryFilter(matchAllQuery()), | ||
| notFilter(andFilter(queryFilter(termQuery("field1", "value1")), | ||
| queryFilter(termQuery("field1", "value2")))))).get(), | ||
| 3l); | ||
| } | ||
| latch.await(); | ||
| } | ||
| } | ||
| } |