Skip to content

Commit

Permalink
Discovery: fix discovery.zen.join_timeout default value logic
Browse files Browse the repository at this point in the history
We default the value to be 20x the value of a ping timeout, however we only use the legacy ping timeout settings value for the calculation.

Closes #13162
  • Loading branch information
bleskes committed Aug 28, 2015
1 parent 49d03a9 commit af07df9
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -163,7 +163,7 @@ public ZenDiscovery(Settings settings, ClusterName clusterName, ThreadPool threa
pingTimeout = settings.getAsTime("discovery.zen.ping_timeout", pingTimeout);
this.pingTimeout = settings.getAsTime(SETTING_PING_TIMEOUT, pingTimeout);

this.joinTimeout = settings.getAsTime(SETTING_JOIN_TIMEOUT, TimeValue.timeValueMillis(pingTimeout.millis() * 20));
this.joinTimeout = settings.getAsTime(SETTING_JOIN_TIMEOUT, TimeValue.timeValueMillis(this.pingTimeout.millis() * 20));
this.joinRetryAttempts = settings.getAsInt(SETTING_JOIN_RETRY_ATTEMPTS, 3);
this.joinRetryDelay = settings.getAsTime(SETTING_JOIN_RETRY_DELAY, TimeValue.timeValueMillis(100));
this.maxPingsFromAnotherMaster = settings.getAsInt(SETTING_MAX_PINGS_FROM_ANOTHER_MASTER, 3);
Expand Down

0 comments on commit af07df9

Please sign in to comment.