Don't rethrow already handled merge exceptions #10083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also changed logger.warn to logger.error... |
|
LGTM but @s1monw should probably look also |
|
LGTM |
mikemccand
pushed a commit
that referenced
this pull request
Mar 13, 2015
We already 1) log the full exception, and 2) fail the engine. Closes #10083
mikemccand
pushed a commit
that referenced
this pull request
Mar 13, 2015
This API is trappy: it secretly does a refresh, which can quickly cause too many segments / OOME if you are also concurrently indexing, and it might delete different documents between primary and replica. It will be removed in 2.0. It's better to do a scan/scroll request with the query, gather the matching ids, and issue a bulk request to delete them. Closes #10083
clintongormley
added
>enhancement
:Core/Infra/Core
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES already has a custom merge exception handler that 1) logs the exception and 2) fails the engine ... and then it calls super, which throws an unhandled exception, which I think is redundant. The JVM catches that and logs it again (to stderr), and this causes test failures like http://build-us-00.elastic.co/job/es_core_1x_centos/3701
I think we should remove the super call?