Remove index.fail_on_merge_failure
#10088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree we should fail all the time on merges @kimchy any historic reasons to not do this? |
|
++, agreed, when we added it, we wanted to have the ability to disable it in case there were problems, but I think its pretty much safe now. |
mikemccand
pushed a commit
to mikemccand/elasticsearch
that referenced
this pull request
Mar 14, 2015
A merge exception is no good ... we should always fail the engine. Closes elastic#10088
clintongormley
changed the title
index.fail_on_merge_failure
clintongormley
added
:Core/Infra/Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10084 deprecates index.fail_on_merge_failure in 1.x and this PR removes it from master.