Fix string comparisons

[slachiewicz]

No description provided.

[javanna]

Hi @slachiewicz in this specific case == works just fine, as long as we make sure that TransportResponseHandler#executor always returns exactly one of the constants listed in ThreadPool.Names class, which we use on the other side of the comparison. This is not really a string comparison though, in order for the result to be true the two variables need to reference the same object (the constant ThreadPool.Names.SAME), regardless of whether they contain the same string.

While equals would make a compiler warning go away, and be less error-prone if things change in the future, == is ok here. What do you think?

[slachiewicz]

Yes, I agree with You, code works correct and we can only remove compiler warnings.
In NettyTransportTests we have code without any warnings ie. Names.SAME.equals(..) call.
I found also this same warning '==' in LocalTransport class (pull attached).
For me it's ok to close this defect if You not prefer to fix this - i found this while working with code merg for netty 4 update.

[javanna]

Thanks @slachiewicz merged.