Add getter for channel in NettyTransportChannel #10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,4 +140,8 @@ public void sendResponse(Throwable error) throws IOException { | |||
| channel.write(buffer); | |||
| transportServiceAdapter.onResponseSent(requestId, action, error); | |||
| } | |||
|
|
|||
| public Channel channel() { | |||
There was a problem hiding this comment.
can we call this getChannel
There was a problem hiding this comment.
sure. Renamed the method
|
LGTM - can you add a doc string |
|
will add doc and push. thanks @s1monw |
|
thank you! |
Adds a getter for the actual netty channel in NettyTransportChannel. The channel can be used by plugins that need access into netty when processing requests.
jaymode
force-pushed
the
netty_transport_channel
branch
from
9d4b7e9
to
a2addaf
Compare
clintongormley
added
the
:Distributed/Network
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a getter for the actual netty channel in NettyTransportChannel. The
channel can be used by plugins that need access into netty when processing
requests.