Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEO] GeoShapeFieldMapper incorrectly acknowledges mapping changes #10513

Closed
nknize opened this issue Apr 9, 2015 · 0 comments · Fixed by #10533
Closed

[GEO] GeoShapeFieldMapper incorrectly acknowledges mapping changes #10513

nknize opened this issue Apr 9, 2015 · 0 comments · Fixed by #10533
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug discuss

Comments

@nknize
Copy link
Contributor

nknize commented Apr 9, 2015

GeoShapeFieldMapper does not overload merge(), so the following request produces
acknowledged: "true" from the AbstractFieldMapper

# update mapping after inserting a shape
PUT geo-shapes/doc/_mapping
{
  "doc": {
    "properties": {
        "geometry": {
          "type": "geo_shape",
          "tree": "quadtree",
          "tree_levels": 26,
          "distance_error_pct": 0
        }
    }
  }
}

This is misleading since changing field parameters has zero impact on the GeoShapeFieldMapper itself leading to a user thinking they're indexing at a higher precision when no change has occurred. This is bad news for query expectations.

This issue will be corrected by overloading merge to add conflicts if certain parameters are changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug discuss
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant