Fix to pom.xml to allow eclipse maven integration using m2e #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
colings86
pushed a commit
that referenced
this pull request
Apr 10, 2015
Update Eclipse core prefs Eclipse Luna overwrites the prefs file, putting all the settings in alphabetical order and removing comments. This causes the prefs files to be modified in the git workspace. Update the file with the version generated by Eclipse to prevent it from being modified every time. No settings values are modified by this change. This also adds another plugin to the lifecycle mapping in the pom.xml which was missed in #10524.
colings86
pushed a commit
that referenced
this pull request
Apr 10, 2015
Update Eclipse core prefs Eclipse Luna overwrites the prefs file, putting all the settings in alphabetical order and removing comments. This causes the prefs files to be modified in the git workspace. Update the file with the version generated by Eclipse to prevent it from being modified every time. No settings values are modified by this change. This also adds another plugin to the lifecycle mapping in the pom.xml which was missed in #10524.
colings86
pushed a commit
that referenced
this pull request
Apr 10, 2015
Update Eclipse core prefs Eclipse Luna overwrites the prefs file, putting all the settings in alphabetical order and removing comments. This causes the prefs files to be modified in the git workspace. Update the file with the version generated by Eclipse to prevent it from being modified every time. No settings values are modified by this change. This also adds another plugin to the lifecycle mapping in the pom.xml which was missed in #10524.
|
w00t |
|
@colings86 Do you think you can also apply this change here? https://github.com/elastic/elasticsearch-parent/blob/master/pom.xml#L719 (in master and 1.x and 1.5 branches)? |
|
Awesome! Thanks a lot @colings86! |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Update Eclipse core prefs Eclipse Luna overwrites the prefs file, putting all the settings in alphabetical order and removing comments. This causes the prefs files to be modified in the git workspace. Update the file with the version generated by Eclipse to prevent it from being modified every time. No settings values are modified by this change. This also adds another plugin to the lifecycle mapping in the pom.xml which was missed in elastic#10524.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although eclipse currently works with the
mvn eclipse:eclipsecommand, this will allow people to enable the m2e maven integration in eclipse.The fix only changes the eclipse lifecycle mapping plugin so will not affect anything outside of the eclipse build. It instructs eclipse to execute the antrun plugin during an incremental or full build in the IDE and to ignore the maven-resources-plugin. The resources plugin is only used for the rpm and deb packaging so is not required for the IDE build.