Deprecate the limit filter.
#10532
Merged
Deprecate the limit filter.
#10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, I have two main motivations to remove this filter:
|
|
If the user already has terminate_after as an alternative, can we issue the deprecation in 1.x? |
|
OK, I'll do that. |
This is really a Collector instead of a filter. This commit deprecates the `limit` filter, makes it a no-op and recommends to use the `terminate_after` parameter instead that we introduced in the meantime.
jpountz
force-pushed
the
deprecate/limit_filter
branch
from
fc91bad
to
5b3cc2f
Compare
jpountz
added a commit
that referenced
this pull request
Apr 10, 2015
Search: deprecate the limit filter. Close #10532
clintongormley
changed the title
limit filter.
im-denisenko
added a commit
to im-denisenko/Elastica
that referenced
this pull request
Sep 17, 2015
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really a Collector instead of a filter. This commit deprecates the
limitfilter, makes it a no-op and recommends to use theterminate_afterparameter instead that we introduced in the meantime.