New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the `limit` filter. #10532

Merged
merged 1 commit into from Apr 10, 2015

Conversation

Projects
None yet
3 participants
@jpountz
Contributor

jpountz commented Apr 10, 2015

This is really a Collector instead of a filter. This commit deprecates the
limit filter, makes it a no-op and recommends to use the terminate_after
parameter instead that we introduced in the meantime.

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Apr 10, 2015

Contributor

For the record, I have two main motivations to remove this filter:

  • it is not cacheable per segment
  • Lucene 5.1 got more sophisticated query execution, and a filter alone cannot be used to limit the total number of hits
Contributor

jpountz commented Apr 10, 2015

For the record, I have two main motivations to remove this filter:

  • it is not cacheable per segment
  • Lucene 5.1 got more sophisticated query execution, and a filter alone cannot be used to limit the total number of hits
@rmuir

This comment has been minimized.

Show comment
Hide comment
@rmuir

rmuir Apr 10, 2015

Contributor

If the user already has terminate_after as an alternative, can we issue the deprecation in 1.x?

Contributor

rmuir commented Apr 10, 2015

If the user already has terminate_after as an alternative, can we issue the deprecation in 1.x?

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Apr 10, 2015

Contributor

OK, I'll do that.

Contributor

jpountz commented Apr 10, 2015

OK, I'll do that.

Search: deprecate the limit filter.
This is really a Collector instead of a filter. This commit deprecates the
`limit` filter, makes it a no-op and recommends to use the `terminate_after`
parameter instead that we introduced in the meantime.

jpountz added a commit that referenced this pull request Apr 10, 2015

Merge pull request #10532 from jpountz/deprecate/limit_filter
Search: deprecate the limit filter.

Close #10532

@jpountz jpountz merged commit 0b413bd into elastic:master Apr 10, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@clintongormley clintongormley changed the title from Search: deprecate the limit filter. to Deprecate the `limit` filter. Jun 6, 2015

@clintongormley clintongormley removed the review label Aug 7, 2015

im-denisenko added a commit to im-denisenko/Elastica that referenced this pull request Sep 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment