Remove duplicated buildAsBytes and corresponding toString methods #11063
Conversation
javanna
added
>enhancement
v2.0.0-beta1
review
:Core/Infra/Transport API
| /** | ||
| * Base class for {@link ToXContent} implementation that also support conversion to {@link BytesReference} for serialization purposes | ||
| */ | ||
| public abstract class ToXContentToBytes implements ToXContent { |
There was a problem hiding this comment.
if you hadn't noticed.... naming is hard... can somebody find a better name for this class please? :)
There was a problem hiding this comment.
Why isn't it just AbstractToXContent?
There was a problem hiding this comment.
because only a small subset of ToXContent implementers will actually need this, good point though I can rename
There was a problem hiding this comment.
I'm fine either way, agreed the name is not obvious here...
There was a problem hiding this comment.
I left ToXContentToBytes for now, wasn't a big fan of the Abstract prefix in this context. BTW this stuff will go away once we are done with the query refactoring. Parsing on the coordinating node will mean streaming intermediate query objects to the data nodes, no json streamed as raw bytes anymore, hence no need for buildAsBytes anymore :)
|
@jpountz can you have a look please? |
|
LGTM |
We parse the rewrite field in FuzzyQueryParser but we don't allow to set it via FuzzyQueryBuilder for our java api users. Added missing field and setter. Closes elastic#11130 Closes elastic#11139
…ethods We have some builders, specifically query builders, `SearchSourceBuilder`, `QuerySourceBuilder` and `SuggestBuilder`, that implement `ToXContent` and also allow to build their content as bytes by simply creating a `BytesReference` that holds their json (or yaml etc.) content (`buildAsBytes` methods). They can also print out their content through `toString`. Made sure that those common methods are in one single place and reused where needed. Also, merged `QueryBuilder` and `BaseQueryBuilder` and made `QueryBuilder` an abstract class instead of an interface.
javanna
force-pushed
the
enhancement/build_as_bytes
branch
from
5ac7f66
to
d4405ac
Compare
clintongormley
changed the title
We have some builders, specifically query builders,
SearchSourceBuilder,QuerySourceBuilderandSuggestBuilder, that implementToXContentand also allow to build their content as bytes by simply creating aBytesReferencethat holds their json (or yaml etc.) content (buildAsBytesmethods). They can also print out their content throughtoString. Made sure that those common methods are in one single place and reused where needed.Also, merged
QueryBuilderandBaseQueryBuilderand madeQueryBuilderan abstract class instead of an interface.