Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuzzyQueryBuilder is missing rewrite #11130

Closed
adamhooper opened this issue May 12, 2015 · 1 comment · Fixed by #11139
Closed

FuzzyQueryBuilder is missing rewrite #11130

adamhooper opened this issue May 12, 2015 · 1 comment · Fixed by #11139
Assignees
@javanna
Labels
>bug :Core/Infra/Transport API Transport client API v1.5.3 v1.6.0 v2.0.0-beta1

Comments

@adamhooper
Copy link

FuzzyQueryBuilder is a MultiTermQueryBuilder, so it should support a rewrite parameter. Indeed, rewrite works when I specify a JSON fuzzy query. But I can't set it if I want to use a FuzzyQueryBuilder.

My workaround is to use MatchQueryBuilder.
javanna added a commit to javanna/elasticsearch that referenced this issue May 13, 2015
@javanna
Java api: add missing rewrite parameter to FuzzyQueryBuilder
1b6a88e 
We parse the rewrite field in FuzzyQueryParser but we don't allow to set it via FuzzyQueryBuilder for our java api users. Added missing field and setter.

Closes elastic#11130
@javanna javanna mentioned this issue May 13, 2015
Merged
@javanna javanna added the :Core/Infra/Transport API Transport client API label May 13, 2015
javanna added a commit to javanna/elasticsearch that referenced this issue May 13, 2015
@javanna
Java api: add missing rewrite parameter to FuzzyQueryBuilder
d2765a2 
We parse the rewrite field in FuzzyQueryParser but we don't allow to set it via FuzzyQueryBuilder for our java api users. Added missing field and setter.

Closes elastic#11130
Closes elastic#11139
javanna added a commit to javanna/elasticsearch that referenced this issue May 13, 2015
@javanna
Java api: add missing rewrite parameter to FuzzyQueryBuilder
7f2f4cf 
We parse the rewrite field in FuzzyQueryParser but we don't allow to set it via FuzzyQueryBuilder for our java api users. Added missing field and setter.

Closes elastic#11130
Closes elastic#11139
javanna added a commit to javanna/elasticsearch that referenced this issue May 13, 2015
@javanna
Java api: add missing rewrite parameter to FuzzyQueryBuilder
c90463a 
We parse the rewrite field in FuzzyQueryParser but we don't allow to set it via FuzzyQueryBuilder for our java api users. Added missing field and setter.

Closes elastic#11130
Closes elastic#11139
@javanna
Copy link
Member

javanna commented May 13, 2015

Thanks @adamhooper good catch, fixed in master, 1.x and 1.5 branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>bug :Core/Infra/Transport API Transport client API v1.5.3 v1.6.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing rewrite parameter to FuzzyQueryBuilder javanna/elasticsearch
2 participants
@adamhooper @javanna