Removing top-level filter parameter from search API. #11600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
added
>enhancement
:Query DSL
:Search/Search
|
Thanks for taking care of this! The change to QueryPhase looks good however I don't think we should keep tests for features we removed, so I think we should just push the change to QueryPhase. |
|
@jpountz Thanks. I was wondering about "negative" tests. I'll remove it. |
|
LGTM |
|
@ycombinator you want to merge it in? master branch only, thanks |
ycombinator
added a commit
that referenced
this pull request
Jun 12, 2015
Removing top-level filter parameter from search API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8862.