detect jar hell before installing a plugin #11963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // before their children (although this makes sense, but is it guaranteed?) | ||
| Files.createDirectories(targetFile.getParent()); | ||
| if (!entry.isDirectory()) { | ||
| OutputStream out = Files.newOutputStream(targetFile); |
There was a problem hiding this comment.
can this be a try / with to close the output stream?
There was a problem hiding this comment.
so much for using @uschindler unzip code :)
Thanks! I will take care of these
|
left some minor comments LGTM otherwise |
rmuir
added a commit
that referenced
this pull request
Jul 1, 2015
detect jar hell before installing a plugin
clintongormley
added
>enhancement
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ES fails on startup if jar hell is created. But its best to fail earlier, when the user tries to install the plugin, and keep the installation healthy.
Fixes #11946