ZenDiscovery: #11960 failed to remove eager reroute from node join #12019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleskes
added
>bug
v2.0.0-beta1
review
:Distributed/Discovery-Plugins
…join This commit fixes it and adds an assert that an initial cluster state from master never has shards assigned to this node
bleskes
force-pushed
the
fix_zen_discovery_node_join_1190
branch
from
d2bb7d3
to
4c04ed4
Compare
|
LGTM |
bleskes
added a commit
that referenced
this pull request
Jul 3, 2015
It is removed now :) Closes #12019
|
pushed to 2.0 & 1.x . Had to remove the assertion as there is a case where the joining node will have shards assigned to it upon first publish - i.e., a master failure followed by another master publishing it's last known state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes it and adds an assert that an initial cluster state from master never has shards assigned to this node