Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fs stats #12053

Merged
merged 1 commit into from Jul 7, 2015
Merged

Update fs stats #12053

merged 1 commit into from Jul 7, 2015

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jul 6, 2015

This pull request:

  • removes the sigar-specific FS stats:
    • fs.*.dev
    • fs.*.disk_reads
    • fs.*.disk_writes
    • fs.*.disk_io_op
    • fs.*.disk_read_size_in_bytes
    • fs.*.disk_write_size_in_bytes
    • fs.*.disk_io_size_in_bytes
    • fs.*.disk_queue
    • fs.*.disk_service_time
  • add default implementation based on JMX beans for other FS stats
  • add documentation for FS stats

@kimchy
Copy link
Member

kimchy commented Jul 7, 2015

can we rename FsStats.Info to FsInfo.Path? other than that, LGTM

@tlrx
FS Stats: remove sigar specific stats from APIs:
fbcf4db 
- fs.*.disk_reads
- fs.*.disk_writes
- fs.*.disk_io_op
- fs.*.disk_read_size_in_bytes
- fs.*.disk_write_size_in_bytes
- fs.*.disk_io_size_in_bytes
- fs.*.disk_queue
- fs.*.disk_service_time
@tlrx tlrx merged commit fbcf4db into elastic:master Jul 7, 2015
@kevinkluge kevinkluge removed the review label Jul 7, 2015
@tlrx
Copy link
Member Author

tlrx commented Jul 7, 2015

@kimchy thanks for the review, I merged it with the renaming to FsInfo.Path.

@tlrx tlrx deleted the update-fs-stats branch July 8, 2015 13:17
@tlrx tlrx mentioned this pull request Jul 8, 2015
Closed
@joegallo joegallo mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>breaking :Data Management/Stats Statistics tracking and retrieval APIs >enhancement v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tlrx @kimchy @kevinkluge