Use IndexWriter.hasPendingChanges() to detect if a flush is needed. #12146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to ensure we flush the indexwriter / commit all changes even if no docs are indexed. This is important if a merge happend after the last flush and no further docs have been added. Otherwise merges will not be committed if no docs where added/updated/deleted. This is equivalent to what master does today. Closes elastic#12134
|
LGTM |
clintongormley
added
the
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to ensure we flush the indexwriter / commit all changes
even if no docs are indexed. This is important if a merge happend after
the last flush and no further docs have been added. Otherwise merges
will not be committed if no docs where added/updated/deleted.
This is equivalent to what master does today.
Closes #12134