Only clear open search ctx if the index is delete or closed via API #12199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martijnvg can you take a look at this |
|
@s1monw that was a sneaky failure. checking the MetaData to see if the index got closed via close api is the right way imo. LGTM |
A change in elastic#12116 introduces closing / cleaning of search ctx even if the index service was closed due to a relocation of it's last shard. This is not desired since in that case it's fine to serve the pending requests from the relocated shard. This commit adds an extra check to ensure that the index is either removed (delete) or closed via API.
s1monw
force-pushed
the
clearn_on_real_close
branch
from
bfd6175
to
2e2bb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in #12116 introduces closing / cleaning of search ctx even if
the index service was closed due to a relocation of it's last shard. This
is not desired since in that case it's fine to serve the pending requests from
the relocated shard. This commit adds an extra check to ensure that the index is
either removed (delete) or closed via API.
there where some failures related to this on CI here:
http://build-us-00.elastic.co/job/es_core_17_centos/50/