Simplify handling of ignored unassigned shards #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fold ignored unassigned to a UnassignedShards and have simpler handling of them. Also remove the trapy way of adding an ignored unassigned shards today directly to the list, and have dedicated methods for it. This change also removes the useless moving of unassigned shards to the end, since anyhow we first, sort those unassigned shards, and second, we now have persistent "store exceptions" that should not cause "dead letter" shard allocation.
kimchy
force-pushed
the
ignore_unassigned
branch
from
5110c5c
to
32445bb
Compare
| // so we give a chance for other allocations and won't create poison failed allocations | ||
| // that can keep other shards from being allocated (because of limits applied on how many | ||
| // shards we can start per node) | ||
| List<ShardRouting> shardsToMove = Lists.newArrayList(); |
There was a problem hiding this comment.
great to see this behaviour move to UnassignedShards!
|
LGTM |
lcawl
added
:Distributed/Distributed
clintongormley
added
:Distributed/Allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold ignored unassigned to a UnassignedShards and have simpler handling of them. Also remove the trappy way of adding an ignored unassigned shards today directly to the list, and have dedicated methods for it.