Copy the classloader from the original settings when checking for prompts #12419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymode
added
>bug
v2.0.0-beta1
review
:Core/Infra/Settings
clintongormley
changed the title
|
Hello, is there ETA for fix of this issue? |
|
|
||
| @Test | ||
| public void testPreserveSettingsClassloader() { | ||
| final ClassLoader classLoader = new URLClassLoader(new URL[] {}); |
There was a problem hiding this comment.
Can we use URLClassLoader.newInstance() instead? It doesn't require a createClassLoader permissions check i think, because the returned subclass is controlled and does proper security checks.
|
Looks good to me. just one note |
…mpts Today, when a user provides settings and specifies a classloader to be used, the classloader gets dropped when we copy the settings to check for prompt entries. This change copies the classloader when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer always retains the classloader. Closes elastic#12340
jaymode
force-pushed
the
fix_settings_classloader
branch
from
c461eba
to
8472775
Compare
jaymode
added a commit
that referenced
this pull request
Jul 23, 2015
Copy the classloader from the original settings when checking for prompts
|
Could you please tell when release with fix of this bug will be built? |
|
@lytvynenkoinvest We try to release regularly and the fix will be released with our next bug fix release, 1.7.1. |
|
Are there expectations about the date of the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.
Closes #12340