Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings' ClassLoader is lost #12340

Closed
ojusti opened this issue Jul 20, 2015 · 0 comments
Closed

Settings' ClassLoader is lost #12340

ojusti opened this issue Jul 20, 2015 · 0 comments
Assignees
@jaymode
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs

Comments

@ojusti
Copy link

ojusti commented Jul 20, 2015

Starting with 1.6.0, custom ClassLoader is lost in org.elasticsearch.node.internal.InternalSettingsPreparer.replacePromptPlaceholders(Settings, Terminal)
@clintongormley clintongormley added >bug :Core/Infra/Settings Settings infrastructure and APIs labels Jul 20, 2015
@clintongormley clintongormley mentioned this issue Jul 23, 2015
Closed
@jaymode jaymode mentioned this issue Jul 23, 2015
Merged
jaymode added a commit to jaymode/elasticsearch that referenced this issue Jul 23, 2015
@jaymode
copy the classloader from the original settings when checking for pro…
8472775 
…mpts

Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.

Closes elastic#12340
jaymode added a commit that referenced this issue Jul 23, 2015
@jaymode
copy the classloader from the original settings when checking for pro…
89bf8c2 
…mpts

Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.

Closes #12340
jaymode added a commit that referenced this issue Jul 23, 2015
@jaymode
copy the classloader from the original settings when checking for pro…
8dda318 
…mpts

Today, when a user provides settings and specifies a classloader to be used, the classloader gets
dropped when we copy the settings to check for prompt entries. This change copies the classloader
when replacing the prompt placeholders and adds a test to ensure the InternalSettingsPreparer
always retains the classloader.

Closes #12340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaymode jaymode

Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @jaymode @ojusti