Skip hidden files #12465
Merged
Skip hidden files #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @xuzha ! |
jpountz
added
>bug
v2.0.0-beta1
:Core/Infra/Plugins
|
I do not think we should use Files.isHidden, anywhere in our code. This is too specific to the OS environment. This should be looking for a match with .DS_Store or startsWith(".") but not looking at any os or filesystem-specific attributes. If we start going this route, then things are going to get confusing quickly. |
|
For the record, I merged this pull request because I saw we were already ignoring hidden files this way in other places, but I'm good with changing hidden file detection to startsWith("."). I opened #12480 |
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Jul 27, 2015
As Robert pointed out on elastic#12465, it has the undesirable property of relying on the operating system. So it would be better to use a simple rule such as checking whether the file name starts with a dot.
|
That's a good point. Thanks Robert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix, skip hidden files when loading plugins. [https://github.com//issues/12433]