Remove hidden file leniency from plugin service #23982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some leniency from the plugin service which skips hidden files in the plugins directory. We really want to ensure the integrity of the plugin folder, so hasta la vista leniency.
jasontedor
added
:Core/Infra/Plugins
|
LGTM |
* master: Discovery EC2: Remove region setting (elastic#23991) AWS Plugins: Remove signer type setting (elastic#23984) Settings: Disallow secure setting to exist in normal settings (elastic#23976) Add registration of new discovery settings Settings: Migrate ec2 discovery sensitive settings to elasticsearch keystore (elastic#23961) Fix throttled reindex_from_remote (elastic#23953) Add comment why we check for null fetch results during merge
This commit adds a test that hidden files are not skipped in the plugins folder.
|
Thanks @rjernst. |
jasontedor
added a commit
that referenced
this pull request
Apr 13, 2017
This commit removes one more instance of leniency from the plugin service which skips hidden files in the plugins directory. Relates #23982
|
I think it's important to point out that a reason that this leniency is so dangerous is because when we install a plugin we explode it into a hidden temporary directory in the plugins folder. If something blows up during plugin installation (which we try to clean up gracefully), this hidden folder will remain. Leniency allows this to go undetected, and that is bad for the user. This leniency is a bug. |
jasontedor
added a commit
that referenced
this pull request
Apr 13, 2017
This commit removes some leniency from the plugin service which skips hidden files in the plugins directory. We really want to ensure the integrity of the plugin folder, so hasta la vista leniency. Relates #23982
jasontedor
added a commit
that referenced
this pull request
Apr 13, 2017
This commit removes one more instance of leniency from the plugin service which skips hidden files in the plugins directory. Relates #23982
|
But this doesn't help users understand what to do - this has occurred for me after initial install. Instead of a solution I get a stack trace and some google treasure hunting until I stumble on this issue. Not a great first impression of ElasticSearch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some leniency from the plugin service which skips hidden files in the plugins directory. We really want to ensure the integrity of the plugin folder, so hasta la vista leniency.
Relates #12465