Installing plugin without checksums ends up downloading from github #13197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadoonet
added
>bug
review
:Core/Infra/Plugins
|
I think we should remove that catch block altogether and just rethrow the first exception from the |
|
@s1monw I pushed a new commit. |
| @@ -153,7 +150,7 @@ public boolean downloadAndVerifyChecksum(URL checksumURL, Path originalFile, Pat | |||
| // checksum file doesn't exist | |||
| return false; | |||
| } catch (IOException e) { | |||
| if (ExceptionsHelper.unwrapCause(e) instanceof FileNotFoundException) { | |||
There was a problem hiding this comment.
you can remove the entire catch (IOException e) block here it's already handled correctly above
There was a problem hiding this comment.
Indeed. That was stupid keeping that.
|
left another comment |
| @@ -378,9 +369,6 @@ private URLConnection openConnection(URL aSource) throws IOException { | |||
| responseCode == HttpURLConnection.HTTP_MOVED_TEMP || | |||
| responseCode == HttpURLConnection.HTTP_SEE_OTHER) { | |||
| String newLocation = httpConnection.getHeaderField("Location"); | |||
| String message = aSource | |||
There was a problem hiding this comment.
@s1monw I removed also this because it's not used in our code. It's unrelated to the change though.
|
@s1monw pushed another commit. |
|
LGTM |
dadoonet
force-pushed
the
fix/13196-pluginmanager-checksum
branch
from
998347d
to
0df3a90
Compare
```sh bin/plugin install lmenezes/elasticsearch-kopf/develop -> Installing lmenezes/elasticsearch-kopf/develop... Trying http://download.elastic.co/lmenezes/elasticsearch-kopf/elasticsearch-kopf-develop.zip ... Trying http://search.maven.org/remotecontent?filepath=lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ... Trying https://oss.sonatype.org/service/local/repositories/releases/content/lmenezes/elasticsearch-kopf/develop/elasticsearch-kopf-develop.zip ... Trying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip ... Downloading .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/develop.zip checksums if available ... Trying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip ... Downloading ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................DONE Verifying https://github.com/lmenezes/elasticsearch-kopf/archive/master.zip checksums if available ... ``` This happens because we don't have anymore ElasticsearchWrapperException here but standard java exceptions. Closes elastic#13196.
dadoonet
force-pushed
the
fix/13196-pluginmanager-checksum
branch
from
0df3a90
to
03bb285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because we don't have anymore ElasticsearchWrapperException here but standard java exceptions.
Closes #13196.