IndexNameExpressionResolver should not ignore any wildcards #13384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
added
>bug
review
:Data Management/Indices APIs
| @@ -604,6 +596,14 @@ public long getStartTime() { | |||
| .stream() | |||
| .filter(e -> Regex.simpleMatch(pattern, e.getKey())) | |||
| .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)); | |||
| } else { | |||
There was a problem hiding this comment.
I'd probably keep the clauses in the order they were in before. Not a big deal though.
|
Left a small comment otherwise it LGTM. |
|
Thx @nik9000 :-) |
xuzha
force-pushed
the
ending-wildcard
branch
from
80dd9d2
to
9a20773
Compare
|
Do we need this for 2.0 and 2.1 @clintongormley ? |
|
Almost certainly 2.1 (2.x branch) and probably not 2.0. Its a bug and doesn't have much chance of breaking anything so I'm for putting it in 2.0 as well. |
|
LGTM @xuzha @nik9000 @clintongormley I think this bugfix should be backported to 2.x and 2.0 |
elsewhere in the expression, closes elastic#13334
xuzha
force-pushed
the
ending-wildcard
branch
from
9a20773
to
c6da8d5
Compare
|
Thanks @nik9000 and @martijnvg for the review. |
|
thank you @xuzha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suffix wildcard case should work for the expression which only has one wildcard in the end.
Fix for #13334.