Date math index names should work too when an index doesn't exist #13570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>bug
review
:Data Management/Indices APIs
| * @return If the specified string is data math expression then this method returns the resolved expression. | ||
| */ | ||
| public String resolveDateMathExpression(String dateExpression) { | ||
| return dateMathExpressionResolver.resolveExpression(dateExpression, new Context(null, null)); |
There was a problem hiding this comment.
the initialization of the context with two null arguments makes me wonder why we don't need those arguments there.
There was a problem hiding this comment.
I'll add an inline comment why null is okay here.
|
left a small comment, LGTM otherwise |
martijnvg
force-pushed
the
date_math_expressions_for_create_index_api
branch
from
1f55b47
to
d809bb5
Compare
… none existing index. Closes elastic#13570
martijnvg
force-pushed
the
date_math_expressions_for_create_index_api
branch
from
d809bb5
to
04cfbe3
Compare
martijnvg
added a commit
that referenced
this pull request
Sep 25, 2015
… none existing index. Closes #13570
martijnvg
added a commit
that referenced
this pull request
Sep 25, 2015
… none existing index. Closes #13570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date math index names should also work when indexing documents into a non existing index.