LoggingRunnable.run should catch and log all errors, not just Exception? #13718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccand
added
>bug
:Core/Infra/Core
|
Makes sense to me. At the root of a Runnable is the one place I've always excused catching Throwable but maybe someone with a more nuanced opinion than I can comment? |
|
LGTM |
mikemccand
pushed a commit
that referenced
this pull request
Sep 23, 2015
LoggingRunnable.run should catch and log all errors, not just Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still digging on #13487 ... and I think it's unlikely this is the cause ...
ThreadPool.scheduleWithFixedDelaywraps the incoming command with aLoggingRunnablewhich runs the command, but catching, suppressing and logging any exceptions. This is important because the JDK'sScheduledThreadPoolExecutor.schedulWithFixedDelaywill stop executing the task if an unhandled exception is hit.But it only catches
Exception... I think maybe it should instead catchThrowable, so that e.g.AssertionErroris also logged?It's remotely possible this test failure is happening because some bad exception (subclassing Error) was hit and the thread is no longer checking for inactive indices ... but then I think the JDK would have sent that exception to stderr, so this is probably not it.