Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename min_similarity to fuzziness #2565

Closed
clintongormley opened this issue Jan 18, 2013 · 10 comments
Closed

Rename min_similarity to fuzziness #2565

clintongormley opened this issue Jan 18, 2013 · 10 comments
Assignees

Comments

@clintongormley
Copy link

Now that fuzziness is really an edit_distance of 1 or 2, we should rename min_similarity in the fuzzy, flt and flt_field queries, and fuzzy_min_sim in the query_string and field queries to fuzziness, which is consistent with the match query.

@s1monw
Copy link
Contributor

s1monw commented Jan 18, 2013

why don't we just call it edit_distance? that is really what it is?

@clintongormley
Copy link
Author

Sure - just for consistency. the use of fuzziness in the match query is probably more self-explanatory than edit_distance

@s1monw
Copy link
Contributor

s1monw commented Jan 18, 2013

@clintongormley I really doubt this, fuzziness is a really bad terms since it relates to different things for different people. Like AI / ML people might confuse it with fuzzy logic. We somehow understand it as not_exact but at the end of the day its a edit_distance on a string with a very specific algorithm.

@clintongormley
Copy link
Author

OK agreed. But I'd make it max_edits rather than edit_distance (shorter and more accurate). And I'd change fuzzy_prefix_length in query_string and field queries to just prefix_length

@s1monw
Copy link
Contributor

s1monw commented Jan 18, 2013

sounds good to me

@uboness
Copy link
Contributor

uboness commented Jan 18, 2013

@clintongormley ++1 on max_edits, I'd also change it on the match query as well

@ankane
Copy link

ankane commented Aug 10, 2013

max_edits would be great since as far as I can tell, there is currently no way to specify an absolute value for the edit distance with fuzziness.

@s1monw
Copy link
Contributor

s1monw commented Aug 11, 2013

@ankane since 0.90 you can specify the absolute edits ie. 1 or 2 as well as a backwards compatible float [0..1)

@ankane
Copy link

ankane commented Aug 11, 2013

@s1monw good to know. Thanks!

@s1monw
Copy link
Contributor

s1monw commented Jan 28, 2014

this has actually been fixed here #4082

@s1monw s1monw closed this as completed Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants