Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify maximum edit distance across fuzzy and match query to max_edits #2568

Closed
wants to merge 1 commit into from

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Jan 18, 2013

Closes #2565

@clintongormley
Copy link

Heya @s1monw

We should probably continue to support the old parameters, even if we remove them from the documentation

@s1monw
Copy link
Contributor Author

s1monw commented Jan 19, 2013

hmm, I kept all old parameters around and deprecated the API getters and setters. This should be fully bw compatible?

@clintongormley
Copy link

Apologies - I didn't read the change carefully enough

@clintongormley
Copy link

This change should also be applied to the query_string https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/index/query/QueryStringQueryParser.java#L164 and field https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/index/query/FieldQueryParser.java#L117 queries.

Also, what should the default be? Currently the min_similarity is 0.5. Change to max_edits: 2?

@clintongormley
Copy link

Similarly, change flt default for max_edits to 2?

@clintongormley
Copy link

How does max_edits affect fuzzy queries when used on numeric or date fields? Does anybody actually do this? A range would surely be more useful.

@s1monw
Copy link
Contributor Author

s1monw commented Jan 29, 2014

invalid has been fixed in a different issue

@s1monw s1monw closed this Jan 29, 2014
@s1monw s1monw deleted the 2565 branch January 29, 2014 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename min_similarity to fuzziness
2 participants