mget REST API should support source parameter #4893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in documentation, we should support `?source=` parameter in mget REST operations.
This is how to reproduce it:
```sh
curl -XDELETE "http://localhost:9200/test"
curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
"foo": "bar"
}'
# This one works
curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
"ids": ["1"]
}'
# This one gives: {"error":"Failed to derive xcontent from org.elasticsearch.common.bytes.BytesArray@0"}
curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```
Closes elastic#4892.
|
@dadoonet can we have a REST spec / test for this as well? Would be great! otherwise looks great |
|
awesome LGTM lets fix that on all applicable branches |
| @@ -48,7 +52,7 @@ | |||
| }, | |||
| "body": { | |||
| "description" : "Document identifiers; can be either `docs` (containing full document information) or `ids` (when index and type is provided in the URL.", | |||
| "required" : true | |||
| "required" : false | |||
There was a problem hiding this comment.
This should still be true. The "body" can be provided to ES in different ways, one of which is the source parameter.
|
Fixed in 0.90, 1.0, 1.x and master branch (2.0) |
clintongormley
added
>bug
v0.90.11
v1.1.0
v2.0.0-beta1
v1.0.0.RC2
:Core/Infra/REST API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in documentation, we should support
?source=parameter in mget REST operations.This is how to reproduce it:
Closes #4892.