Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific loggers in subclasses of TMNA #50076

Conversation

DaveCTurner
Copy link
Contributor

Adjusts the subclasses of TransportMasterNodeAction to use their own loggers
instead of the one for the base class.

Relates #50056.
Partial backport of #46431 to 7.x.

Adjusts the subclasses of `TransportMasterNodeAction` to use their own loggers
instead of the one for the base class.

Relates elastic#50056.
Partial backport of elastic#46431 to 7.x.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@DaveCTurner
Copy link
Contributor Author

@elasticmachine please run elasticsearch-ci/packaging-sample-matrix

@DaveCTurner DaveCTurner merged commit 285eacd into elastic:7.x Dec 11, 2019
@DaveCTurner DaveCTurner deleted the 2019-12-11-backport-logger-changes-from-46431 branch December 11, 2019 15:07
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@davidkyle
Copy link
Member

@DaveCTurner I've raised #50839 to backported this to 7.5.2 for the benefit of all those 7.5 users

@davidkyle
Copy link
Member

I've added the non-issue label as I do not want this change to appear in the release notes.
#50839 is actually a couple of changes (this and #50074) merged into a single change and I don't want both those fixes to be documented in the release notes.

#50839 -which encompasses this change- will be in the 7.5.2 release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants