Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended debug logging in subclasses of TransportMasterNodeAction #50839

Merged
merged 2 commits into from Jan 10, 2020

Conversation

davidkyle
Copy link
Member

Adjusts the subclasses of TransportMasterNodeAction to use their own loggers instead of the one for the base class. Fixes an issue where subclasses of o.e.a.s.m.TransportMasterNodeAction were logging debug messages by default.

Backport of #50074 and #50076
For #50056

DaveCTurner and others added 2 commits January 10, 2020 08:14
Adjusts the subclasses of `TransportMasterNodeAction` to use their own loggers
instead of the one for the base class.

Relates elastic#50056.
Partial backport of elastic#46431 to 7.x.
@davidkyle davidkyle added >enhancement :Core/Infra/Core Core issues without another label v7.5.2 labels Jan 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please can you change the PR title to something more specific as it will appear in the release notes

@davidkyle davidkyle changed the title Fix spammy loggers Subclasses of TransportMasterNodeAction should use their own loggers Jan 10, 2020
@davidkyle davidkyle changed the title Subclasses of TransportMasterNodeAction should use their own loggers Fix unintended debug logging in subclasses of TransportMasterNodeAction Jan 10, 2020
@davidkyle davidkyle merged commit ed3b436 into elastic:7.5 Jan 10, 2020
@davidkyle davidkyle deleted the fix-spammy-loggers branch January 10, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement v7.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants