Added support for sorting buckets based on sub aggregation down the current hierarchy #5340
Conversation
| } | ||
| } | ||
| } | ||
| -------------------------------------------------- |
There was a problem hiding this comment.
Does this example actually make sense? Since stats are computed on the same field that is used for the histogram, this order is equivalent to _key: desc?
There was a problem hiding this comment.
indeed :D... will change it to popularity?
|
This change looks good, I particularly appreciate that the aggregator that is used for comparisons is computed up-front. |
yeah, agreed... in particular, verify that aggregation names don't include |
Supports sorting on sub-aggs down the current hierarchy. This is supported as long as the aggregation in the specified order path are of a single-bucket type, where the last aggregation in the path points to either a single-bucket aggregation or a metrics one. If it's a single-bucket aggregation, the sort will be applied on the document count in the bucket (i.e. doc_count), and if it is a metrics type, the sort will be applied on the pointed out metric (in case of a single-metric aggregations, such as avg, the sort will be applied on the single metric value) NOTE: this commit adds a constraint on what should be considered a valid aggregation name. Aggregations names must be alpha-numeric and may contain '-' and '_'. Closes #5253
|
Looks good to me! |
clintongormley
added
>enhancement
v1.1.0
v2.0.0-beta1
:Analytics/Aggregations
clintongormley
changed the title
This is supported as long as the aggregation in the specified order path are of a single-bucket type, where the last aggregation in the path points to either a single-bucket aggregation or a metrics one. If it's a single-bucket aggregation, the sort will be applied on the document count in the bucket (i.e. doc_count), and if it is a metrics type, the sort will be applied on the pointed out metric (in case of a single-metric aggregations, such as avg, the sort will be applied on the single metric value)
Closes #5253